Skip to content

Fix #366: Export PromoteNewMaster, handle sequence zero #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Kaustubh1204 wants to merge 1 commit into
base: unstable
Choose a base branch
from
Open

Fix #366: Export PromoteNewMaster, handle sequence zero #373

Kaustubh1204 wants to merge 1 commit into from
+19 −11

Conversation

@Kaustubh1204
Copy link

@Kaustubh1204 Kaustubh1204 commented Jan 17, 2026

  • Exported promoteNewMaster method to PromoteNewMaster to fix build error
  • Fixed failover validation to allow sequence == 0 when master is also 0
  • Resolves issue Failover failed because of sequence is 0 #366 where failover failed with empty shards

@Kaustubh1204
Fixed Build Error in
43766bd 
cluster_shard.go(Failover failed because of sequence is 0 apache#366)
@git-hulk
Copy link
Member

git-hulk commented Jan 18, 2026

@Kaustubh1204 Thanks for your contribution.

Exported promoteNewMaster method to PromoteNewMaster to fix build error

I cannot see when the build error, could you please elaborate a bit?

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.23%. Comparing base (6c56470) to head (43766bd).
⚠️ Report is 104 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable     #373      +/-   ##
============================================
+ Coverage     43.38%   49.23%   +5.84%     
============================================
  Files            37       45       +8     
  Lines          2971     3790     +819     
============================================
+ Hits           1289     1866     +577     
- Misses         1544     1716     +172     
- Partials        138      208      +70
Flag Coverage Δ
unittests 49.23% <100.00%> (+5.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kaustubh1204 @git-hulk @codecov-commenter